Skip to content

Conversation

lvivier
Copy link
Contributor

@lvivier lvivier commented Nov 1, 2015

ref #532

Enables the JSON1 extension added in 3.9.0, and adds a test to confirm the json() function exists.

@lvivier
Copy link
Contributor Author

lvivier commented Nov 1, 2015

@Mithgol I've only added a simple test to confirm the existence of json(), modeled on the fts test. If you think we should do more, just say so.

@lvivier lvivier mentioned this pull request Nov 1, 2015
Mithgol added a commit that referenced this pull request Nov 1, 2015
Enable json1 extension by default
@Mithgol Mithgol merged commit ecb4f3c into TryGhost:master Nov 1, 2015
@Mithgol
Copy link
Contributor

Mithgol commented Nov 1, 2015

Thanks for your contribution.

In a Travis CI job I've seen that the test passes successfully in “our” built SQLite but then fails when the shared (the local system's) SQLite is tested.

That's normal because that SQLite is not expected to have SQLITE_ENABLE_JSON1 enabled.

I'm going to mark the test as pending for now (fe4812e).

In the future we might want to skip this test only when the shared SQLite is tested (however, I don't know if Mocha permits this idea).

@Mithgol
Copy link
Contributor

Mithgol commented Nov 1, 2015

I guess I'd better try a change in the system's environment.

@Mithgol
Copy link
Contributor

Mithgol commented Nov 1, 2015

My changes (1fcb843) seem fine, the test now depends on the SQLite version (“our” or the system's) being tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants